Build: Fix publish script#23948
Merged
Merged
Conversation
ndelangen
added
build
ndelangen
force-pushed
the
norbert/fix-no-linking-publish
branch
from
cfc727e to
3026181
Compare
ndelangen
requested review from
JReinhold,
cdedreuille,
tmeasday and
valentinpalkovic
as code owners
Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>
15 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I found out that when running the local registry the
workspace:*version ranges were present inside the package.json files by the local registry.They should be replaced by running
yarn pack.I found that
yarn packis working as advertised, but there's a bug in the npm CLI: npm/cli#4533.This bug causes the tarball CLI parameter to get ignored.
@JReinhold and me figured out that the way around the npm bug is to generate the tarball to a different directory and publish from there.
We hypothesise the npm bug somehow only occurs when npm can find a package.json with the same name upwards.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task publish -s install --no-link.verdaccio-cache/@storybook/addon-a11y/package.json"workspace:*"Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>