Skip to content

CLI: Pass package manager to postinstall#23913

Merged
ShaunEvening merged 9 commits into
nextfrom
shaun/pass-package-manager
Aug 25, 2023
Merged

CLI: Pass package manager to postinstall#23913
ShaunEvening merged 9 commits into
nextfrom
shaun/pass-package-manager

Conversation

@ShaunEvening
Copy link
Copy Markdown
Contributor

@ShaunEvening ShaunEvening commented Aug 22, 2023

What I did

  • Pass the name of the package manager as an option to the postinstall script
  • Create a postinstall script for addon-themes
  • Don't add ^ to version if the specified version isn't semver (Example : next, canary)

Checklist for Contributors

Testing

Manual testing

  1. Open a sandbox of your choosing
  2. yarn add -D tailwindcss postcss autoprefixer
  3. npx storybook@canary add @storybook/addon-themes@canary
  4. @storybook/auto-config should be run to configure tailwind themes

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-23913-sha-45573ae9. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-23913-sha-45573ae9
Triggered by @ndelangen
Repository storybookjs/storybook
Branch shaun/pass-package-manager
Commit 45573ae9
Datetime Wed Aug 23 14:35:40 UTC 2023 (1692801340)
Workflow run 5952768837

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23913

@storybook-bot
Copy link
Copy Markdown
Contributor

Failed to publish canary version of this pull request, triggered by @integrayshaun. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/5939042720

@ShaunEvening ShaunEvening added the ci:normal Run our default set of CI jobs (choose this for most PRs). label Aug 23, 2023
Comment thread code/lib/cli/src/add.ts Outdated
@ShaunEvening ShaunEvening requested a review from shilman August 24, 2023 22:58
@ShaunEvening ShaunEvening merged commit f83212b into next Aug 25, 2023
@ShaunEvening ShaunEvening deleted the shaun/pass-package-manager branch August 25, 2023 12:51
@github-actions github-actions Bot mentioned this pull request Aug 25, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). cli feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants