Maintenance: Remove need for react as peerDependency#23897
Merged
ndelangen merged 3 commits intoAug 24, 2023
Merged
Conversation
…as peerDependency""
react as peerDependencyreact as peerDependency
Contributor
|
Hey @ndelangen can you please fill out "how to test" and specifically include the steps to ensure the previous breakage doesn't happen again? |
…dep-webpack-builder-removal
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reverts #23882
What I did
I found out the problem that was causing #23876, so instead of reverting the whole thing, we fix it proper.
How to test
To reproduce:
v1.7.161tag, which is where the issue was found: https://github.com/mkosir/react-parallax-tilt/tree/v1.7.161npm run start-storybook- it should work@storybook/addon-essentialsand@storybook/manager-apinpm installthennpm run start-storybook- it should fail0.0.0-pr-23897-sha-78c2d886npm run start-storybook- it should work!Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This pull request has been released as version
0.0.0-pr-23897-sha-78c2d886. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-23897-sha-78c2d886revert-23882-revert-23496-norbert/react-peerdep-webpack-builder-removal78c2d8861692602787)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23897