Documentation: Add contributing note for disabling actions in forks#23801
Merged
Conversation
Contributor
Author
|
Ok, failing on Danger JS 😳 - I made the docs changes in the GH site. I'll pull down the PR locally and have a look in a bit. |
Contributor
Author
|
Am getting errors running |
Contributor
Author
|
Ok, the failing CI on this PR is unrelated to my local issues so setting back to review. |
1bd4afc to
b08e357
Compare
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
kylegach
reviewed
Aug 14, 2023
Contributor
kylegach
left a comment
There was a problem hiding this comment.
Thanks for these improvements, @johnhunter!
I left some suggested further improvements for you to integrate, then we can merge.
559bd4f to
24d0358
Compare
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
24d0358 to
79170a9
Compare
kylegach
reviewed
Aug 15, 2023
kylegach
approved these changes
Aug 16, 2023
Contributor
kylegach
left a comment
There was a problem hiding this comment.
Nicely done! Thanks again, @johnhunter.
This was referenced Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How to test
Documentation only.
If required you can confirm contributing guide link does not 404.
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>