#23708 Add volta pin settings and duplicate packageManager setting#23709
Merged
ndelangen merged 2 commits intoAug 7, 2023
Conversation
and duplicate packageManager setting.
2288ae8 to
4967cf1
Compare
ndelangen
approved these changes
Aug 7, 2023
Member
|
Thank you @johnhunter, this is great! |
14 tasks
Contributor
Author
|
Thanks @ndelangen I had some good feedback on discourse suggesting we should not be prescriptive about node versions but rather include various node versions in the CI tests. That would be a great approach but we have quite big CI matrix as it is - maybe one for a future discussion 😀 |
Member
|
We considering dropping support for node16 a breaking change, (node 16 is the minimum requirement for storybook). In 8.0 we're dropping node16 support, and then will make the switch to CI run node18 as well. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23708
What I did
packageManager:yarnversion into the volta settings.How to test
yarn startyou should see the volta shim first install required node and yarn versions
yarn testChecklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>