Skip to content

#23708 Add volta pin settings and duplicate packageManager setting#23709

Merged
ndelangen merged 2 commits into
storybookjs:nextfrom
johnhunter:volta-corepack-incompatibility
Aug 7, 2023
Merged

#23708 Add volta pin settings and duplicate packageManager setting#23709
ndelangen merged 2 commits into
storybookjs:nextfrom
johnhunter:volta-corepack-incompatibility

Conversation

@johnhunter
Copy link
Copy Markdown
Contributor

Closes #23708

What I did

  • Added volta pin settings to the root package.json. This has no impact if Volta is not used for node version management. However, since setup indicates we should use a specific node version it might be useful to support it.
  • Duplicated the packageManager:yarn version into the volta settings.
  • Updated documentation for optional use of Volta

How to test

  1. With a fresh storybook repo
  2. Install Volta (if not already installed)
  3. Run yarn start
    you should see the volta shim first install required node and yarn versions
  4. Run yarn test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@johnhunter johnhunter force-pushed the volta-corepack-incompatibility branch from 2288ae8 to 4967cf1 Compare August 3, 2023 14:50
@ndelangen ndelangen self-assigned this Aug 7, 2023
@ndelangen ndelangen added build Internal-facing build tooling & test updates patch:no labels Aug 7, 2023
@ndelangen ndelangen merged commit 2ccaa7d into storybookjs:next Aug 7, 2023
@ndelangen
Copy link
Copy Markdown
Member

Thank you @johnhunter, this is great!

@github-actions github-actions Bot mentioned this pull request Aug 7, 2023
14 tasks
@johnhunter
Copy link
Copy Markdown
Contributor Author

Thanks @ndelangen I had some good feedback on discourse suggesting we should not be prescriptive about node versions but rather include various node versions in the CI tests. That would be a great approach but we have quite big CI matrix as it is - maybe one for a future discussion 😀

@ndelangen
Copy link
Copy Markdown
Member

We considering dropping support for node16 a breaking change, (node 16 is the minimum requirement for storybook).

In 8.0 we're dropping node16 support, and then will make the switch to CI run node18 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: volta and corepack incompatibility on yarn start

2 participants