Automigration: Fix wrap-require automigration for common js main.js files #23644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
requested review from
kasperpeulen,
shilman,
yannbf and
ndelangen
as code owners
valentinpalkovic
added
patch:yes
valentinpalkovic
changed the title
valentinpalkovic
deleted the
valentin/support-cjs-in-wrap-require-automigration
branch
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
This was referenced Jul 28, 2023
Closed
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…ap-require-automigration Automigration: Fix wrap-require automigration for common js main.js files (cherry picked from commit dc9ac08)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23637
What I did
Fixed wrap-require automigration for common js main.js files
How to test
Follow the reproduction in #23637
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>