Scripts: Improve check task to allow for running with linking#23498
Merged
Conversation
…eally do any good anyway
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I was annoyed by the fact I could only run
nr task checkwith--no-link.So by calling
tsc's node apis and manually filtering diagnostic messages to only those coming from thecwd, I was able to get exactly this!This also opens up the option of adding different "check" actions, such as #knip maybe.
I was also considering some check actions like https://www.npmjs.com/package/check-peer-dependencies or https://github.com/rwjblue/validate-peer-dependencies
The CI still runs the
checktask with--no-link.How to test
yarn task check -s compilevue&svelteuse some customtscclone, and I didn't want to invest time there.Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]