Docs: fix readme storyshots link#23467
Merged
jonniebigodes merged 2 commits intoJul 20, 2023
Merged
Conversation
Contributor
|
@kawokas thanks for taking the time to put together this pull request and catch that small but rather important issue in the documentation. Appreciate it 🙏 ! I've checked and all is good on my end. I'll merge it once the checklist clears. Hope you have a fantastic day. Stay safe |
jonniebigodes
approved these changes
Jul 20, 2023
Contributor
Author
|
@jonniebigodes I changed the Workflow permissions setting to read and write permission, so I think Danger JS CI will pass if you re-run it. thank you ! |
Contributor
|
@kawokas, no need to thank whatsoever; it was my pleasure, and don't worry about the Danger JS issue. We're aware of it and we'll soon have it addressed to accommodate pull requests similar to this one. |
11 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Merged
14 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The link to storyshots in the README was broken. I have fixed this.
How to test
README link to storyshots jumps correctly
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]