CLI: Improve support of mono repositories#23458
Merged
Merged
Conversation
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
yannbf
reviewed
Jul 14, 2023
cda3ae7 to
e2a33c5
Compare
Contributor
Author
What should happen? -> Nothing will happen ;) We are doing AST analysis, so we don't follow the path of their base config. They would have to apply the changes manually. There is no chance for us to figure out whether we have to run the auto migrations. An edge case we can safely ignore. It's not worth supporting it in the auto migrations. |
c08bba7 to
4c3e892
Compare
Merged
14 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 24, 2023
…y-setups CLI: Improve support of mono repositories (cherry picked from commit 5b34161)
legnaleurc
pushed a commit
to legnaleurc/storybook
that referenced
this pull request
Sep 6, 2023
In monorepo, the framework name will be an absolute path. A follow up for storybookjs#23458.
8 tasks
legnaleurc
pushed a commit
to legnaleurc/storybook
that referenced
this pull request
Sep 6, 2023
In monorepo, the framework name will be an absolute path. A follow up for storybookjs#23458.
legnaleurc
added a commit
to legnaleurc/storybook
that referenced
this pull request
Sep 7, 2023
In monorepo, the framework name will be an absolute path. A follow up for storybookjs#23458.
legnaleurc
added a commit
to legnaleurc/storybook
that referenced
this pull request
Sep 7, 2023
In monorepo, the framework name will be an absolute path. A follow up for storybookjs#23458.
legnaleurc
added a commit
to legnaleurc/storybook
that referenced
this pull request
Sep 8, 2023
In monorepo, the framework name will be an absolute path. A follow up for storybookjs#23458.
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21216
Closes #21710
What I did
Improved support for mono repositories to apply the "wrapForPnp" wrapper also in mono repository environments. Additionally, an auto migration was added.
Improved support for projects which are part of a workspace configured by yarn, npm, pnpm, lerna, turbo or rush
How to test
yarn exec <storybook-project-folder>/code/lib/cli/bin/index.js automigratefor the automigration oryarn exec <storybook-project-folder>/code/lib/cli/bin/index.js initto initialize Storybook. Otherwise, you can ditch theyarn execpart.main.tsare properly wrapped by thewrapForPnporgetAbsolutePathwrapper.main.tsandmain.jsfiles.Tested scenarios:
getAbsolutePathorwrapForPnpfunctions are in place)Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]