Skip to content

Release tooling: Fix new patch labels #23407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 1 commit into from
Jul 11, 2023
Merged

Release tooling: Fix new patch labels #23407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/release/__tests__/generate-pr-description.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Generate PR Description', () => {
id: 'pr-id-11',
user: 'shilman',
title: 'Another PR `title` for docs',
labels: ['another label', 'documentation', 'patch'],
labels: ['another label', 'documentation', 'patch:yes'],
commit: 'ddd222',
pull: 11,
links: {
Expand Down Expand Up @@ -104,7 +104,7 @@ describe('Generate PR Description', () => {
"- [ ] **🐛 Bug**: Some PR title for a bug [#42](https://github.com/storybookjs/storybook/pull/42) (will also be patched)
- [ ] **✨ Feature Request**: Some PR title for a 'new' feature [#48](https://github.com/storybookjs/storybook/pull/48)
- [ ] **⚠️ Direct commit**: Some title for a "direct commit" [22bb11](https://github.com/storybookjs/storybook/commit/22bb11)
- [ ] **📝 Documentation**: Another PR \`title\` for docs [#11](https://github.com/storybookjs/storybook/pull/11)
- [ ] **📝 Documentation**: Another PR \`title\` for docs [#11](https://github.com/storybookjs/storybook/pull/11) (will also be patched)
- [ ] **❔ Missing Label**: Some PR title with a missing label [#77](https://github.com/storybookjs/storybook/pull/77)"
`);
});
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/utils/get-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export const mapToChanges = ({
return;
}
// filter out any entries that are not patches if unpickedPatches is set. this will also filter out direct commits
if (unpickedPatches && !entry.labels?.includes('patch')) {
if (unpickedPatches && !entry.labels?.includes('patch:yes')) {
return;
}
changes.push(entry);
Expand Down