Fix duplicate name for interface and function#23350
Merged
Merged
Conversation
a function can't have the same name as an interface, in addition to that, DocumentScreen is imported and used as a component and not as an interface in other files.
jonniebigodes
added
documentation
patch:yes
jonniebigodes
approved these changes
Jul 7, 2023
Contributor
jonniebigodes
left a comment
jonniebigodes
left a comment
There was a problem hiding this comment.
@ubugnu thanks for taking the time to put together this pull request and help us improve our documentation by catching this small but rather important typo. Appreciate it 🙏 . I've checked it and will merge it once the checklist clears.
Hope you have a fantastic weekend.
Stay safe
JReinhold
pushed a commit
that referenced
this pull request
Jul 7, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
This was referenced Jul 7, 2023
Merged
JReinhold
pushed a commit
that referenced
this pull request
Jul 8, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
8 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
JReinhold
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
JReinhold
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
JReinhold
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
JReinhold
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Fix duplicate name for interface and function (cherry picked from commit 33b7443)
github-actions
Bot
added
the
patch:done
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a function can't have the same name as an interface, in addition to that, DocumentScreen is imported and used as a component and not as an interface in other files.
What I did
I fixed a typescript error
How to test