Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Update docs version files when releasing #23235

Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jun 27, 2023

Closes #23000

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold linked an issue Jun 27, 2023 that may be closed by this pull request
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Jun 27, 2023
@JReinhold JReinhold self-assigned this Jun 27, 2023
@JReinhold JReinhold marked this pull request as ready for review June 27, 2023 21:03
verbose?: boolean;
}) => {
const isPrerelease = semver.prerelease(version) !== null;
const filename = isPrerelease ? 'next.json' : 'latest.json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you ensure that this never gets called in any other scenarios? Future release? Canary release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. For now we only support the two release types, so it's hard to come up with how the logic would be if there were other types of releases here.

@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 4, 2023
@shilman shilman merged commit 35fc07b into next Jul 4, 2023
2 checks passed
@shilman shilman deleted the 23000-bug-new-release-flow-doesnt-update-versions-on-docs-site branch July 4, 2023 08:52
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
…-doesnt-update-versions-on-docs-site

Release tooling: Update docs version files when releasing

(cherry picked from commit 35fc07b)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: New release flow doesn't update versions on docs site
2 participants