Build: Fix parallelism count#23203
Merged
Merged
Conversation
f82ec7d to
5e1daf8
Compare
5e1daf8 to
7befc4c
Compare
ndelangen
approved these changes
Jun 24, 2023
12 tasks
This was referenced Jul 2, 2023
Merged
Merged
Merged
Closed
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Apart from fixing the count, I improved the
yarn get-templatescript so when it fails, it provides a proper answer that guides us with exactly what parallelism values we need put to fix the issue:You can also run the command locally before pushing:
If you specify a task but not a cadence, it shows that task for all cadences:
If you specify a cadence, but not a task, it shows all tasks for that given cadence:
If you do not specify anything, it shows every cadence and every task:
A future iteration could, instead of logging the information, just automatically update the yml file instead.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]