Docs: Document release tooling#23181
Merged
Merged
Conversation
vanessayuenn
left a comment
Contributor
There was a problem hiding this comment.
This is so comprehensive! Good work 🔥🔥🔥
I have a couple of nits around the wording -- left suggestions for those. Regarding release cadence, I think we need to discuss it more thoroughly before writing anything down in a public document. I suggest leaving this topic out of the current document and instead discussing it as a team at the offsite next week. Once we have come to an agreement, we can commit to it in writing.
Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
jonniebigodes
requested changes
Jun 22, 2023
jonniebigodes
left a comment
Contributor
There was a problem hiding this comment.
@JReinhold, this is amazing. Fantastic job on this. I left a couple of nits regarding phrasing for you to consider. Let me know and we'll go from here.
Contributor
Author
|
@jonniebigodes @vanessayuenn I've adressed all your comments now. |
jonniebigodes
approved these changes
Jun 23, 2023
vanessayuenn
approved these changes
Jun 23, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22609
What I did
Added documentation for the release tooling and process. See this for a rendered version:
https://github.com/storybookjs/storybook/blob/release-docs/CONTRIBUTING/RELEASING.md
I just added it at
CONTRIBUTING/RELEASING.mdbut I don't care much about where this documentation lives, inputs are welcome. I don't think it's appropriate in the contribute section on the docs site thoughHow to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]