React: Move typescript from devDependencies to peerDependencies#23179
Merged
Conversation
5 tasks
ndelangen
requested changes
Jun 27, 2023
kasperpeulen
reviewed
Jul 3, 2023
Contributor
|
@chakAs3 based on the CI failure I think you forgot to update the lock file when you set |
ndelangen
approved these changes
Jul 10, 2023
14 tasks
shilman
changed the title
typescript from devDependencies to peerDependenciestypescript from devDependencies to peerDependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
cra/default-js or any project using @storybook/react will break in runtime, if typescript was not provided, to fix that react should have it peerDeps with optional=true in peerDependenciesMeta
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]