Docs: Define Storybook's RFC process#23138
Merged
Merged
Conversation
vanessayuenn
changed the title
JReinhold
reviewed
Jun 19, 2023
valentinpalkovic
approved these changes
Jun 20, 2023
kylegach
reviewed
Jun 20, 2023
kylegach
reviewed
Jun 20, 2023
kylegach
reviewed
Jun 20, 2023
kylegach
previously requested changes
Jun 20, 2023
Contributor
kylegach
left a comment
kylegach
left a comment
There was a problem hiding this comment.
Thanks, Vanessa! The content looks great to me, but I left a comment about the file's location that must be addressed.
jonniebigodes
requested changes
Jun 20, 2023
Contributor
jonniebigodes
left a comment
jonniebigodes
left a comment
There was a problem hiding this comment.
@vanessayuenn left one item for you to look into that I'm more than glad to follow up with. Let me know and we'll go from there.
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
kylegach
dismissed
their stale review
I'll let João manage it from here, as he has an identical understanding (and then some).
jonniebigodes
approved these changes
Jul 5, 2023
Contributor
|
Will merge once the checklist clears. Once again thanks for putting this together @vanessayuenn. 🙏 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
feature requestto opening a GitHub discussion instead of an issue (cc @shilman)issues/newOutstanding tasks
contributingfor now, but @jonniebigodes @kylegach if you have thoughts on where this should live long term, please let me know.Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]