Core: Prebundle node-logger and make it CJS only#23109
Merged
Merged
Conversation
Member
Author
|
In my experiment to change the bundle script for CJS dist, the NX remote cache was corrupted somehow. |
a3fc22f to
8cde3f3
Compare
This was referenced Jun 17, 2023
Merged
Merged
18 tasks
tjfred35
reviewed
Oct 18, 2023
| "node": "./dist/index.js", | ||
| "require": "./dist/index.js", | ||
| "import": "./dist/index.mjs" | ||
| "require": "./dist/index.js" |
There was a problem hiding this comment.
I have a setup (nx / vite) where I need the "import" declaration -- in this case, adding back "import": "./dist/index.js" would solve my issue while still using a "prebundled" version of node-logger?
This broke our upgrade from storybook 7.0.24 to 7.4.46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was alerted about this stack trace by @integrayshaun :
We traced it to
wide-align/align.jsindeed callingrequire('string-width'), which is not allowed by JS law.I prebundled
node-logger, meaning all dependencies are now bundled in.