Experimental: Add API for addons to inject full-view 'pages'#23081
Closed
ndelangen wants to merge 44 commits into
Closed
Experimental: Add API for addons to inject full-view 'pages'#23081ndelangen wants to merge 44 commits into
ndelangen wants to merge 44 commits into
Conversation
ndelangen
commented
Jun 15, 2023
| children: ReactNode; | ||
| } | ||
| interface RoutePropsDefault { | ||
| path: string | RegExp; |
Member
Author
There was a problem hiding this comment.
It supports RegExp now!
ndelangen
commented
Jun 15, 2023
| ); | ||
|
|
||
| export const childrenToList = (children: any, selected: string) => | ||
| export const childrenToList = (children: TabsProps['children']) => |
Member
Author
There was a problem hiding this comment.
The tabs component is due for a complete overhaul.
The API is has with the children being the interface was not a great idea of mine.
It was hard to get the title to show up and not lose state when the tab became active/inactive.
ndelangen
commented
Jun 15, 2023
ndelangen
commented
Jun 15, 2023
Comment on lines
56
to
74
| <S.Main {...mainProps} isFullscreen={!!mainProps.isFullscreen}> | ||
| <S.Preview {...previewProps} hidden={viewMode === 'settings'}> | ||
| <Preview id="main" /> | ||
| </S.Preview> | ||
| <Route path={/^\/story|docs\//} hideOnly> | ||
| <S.Preview {...previewProps} hidden={false}> | ||
| <Preview id="main" /> | ||
| </S.Preview> | ||
|
|
||
| <S.Panel {...panelProps} hidden={viewMode !== 'story'}> | ||
| <Panel /> | ||
| </S.Panel> | ||
| <Route path="/story/" startsWith hideOnly> | ||
| <S.Panel {...panelProps} hidden={false}> | ||
| <Panel /> | ||
| </S.Panel> | ||
| </Route> | ||
| </Route> | ||
|
|
||
| {pages.map(({ key, route: Route, render: Content }) => ( | ||
| <Route key={key}> | ||
| {pages.map(({ key, route: Wrapper, render: Content }) => ( | ||
| <Wrapper key={key}> | ||
| <Content /> | ||
| </Route> | ||
| </Wrapper> | ||
| ))} | ||
| </S.Main> |
Member
Author
There was a problem hiding this comment.
settings is now no longer some special string anymore.
ndelangen
commented
Jun 15, 2023
| <Content /> | ||
| </Route> | ||
| ))} | ||
| export const Mobile = ({ |
Member
Author
There was a problem hiding this comment.
The mobile view was such a mess, pages would show up, but then make it impossible to go back to canvas.
This needs more attentions and proper testing.
I suspect there's a range of pre-existing bugs still here
ndelangen
commented
Jun 15, 2023
| ); | ||
| }; | ||
|
|
||
| export const JSXTitles = () => { |
Member
Author
There was a problem hiding this comment.
Demonstrating addon titles being a React.FC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted into steps PRs:
Router change:
#23292
Tabs accepting title as
FC:#23288
Addon interactions overhaul using title as
FCanduseAddonState:#23291
Other addons:
#23298
The big bang:
#23307