Controls: Fix UI to add array items#22993
Merged
Merged
Conversation
ndelangen
approved these changes
Jun 21, 2023
Member
|
Thank you so much for your contribution @sookmax <3 |
7 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 2, 2023
Controls: Fix UI to add array items (cherry picked from commit 4f7342b)
Merged
15 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22903
What I did
I applied the same style to
.rejt-array-node > span > *as.rejt-object-node > span > *The bug was caused by the plus button being not clickable because it is obscured by the pseudo element in the same level (
.rejt-not-collapsed::before), which is absolutely positioned with z-index 1. So by applyingposition: relativeandz-index: 2to the selector.rejt-array-node > span > *, the plus button can now be interacted if the object is an array as well.How to test
yarn task --task sandbox --start-from auto --template react-vite/default-tssandbox/react-vite-default-ts/src/stories/Button.stories.tsarrayfield.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]