Skip to content

Core: Fix builder-manager adding multiple dashes to relative path#22974

Merged
ndelangen merged 3 commits into
storybookjs:nextfrom
MarioCadenas:fix/build-manager-path-generation
Jun 8, 2023
Merged

Core: Fix builder-manager adding multiple dashes to relative path#22974
ndelangen merged 3 commits into
storybookjs:nextfrom
MarioCadenas:fix/build-manager-path-generation

Conversation

@MarioCadenas

Copy link
Copy Markdown
Contributor

Closes #

What I did

When building a standalone storybook, using the function buildStaticStandalone and having a manager.ts inside the main configDir of storybook, the folder generated inside the storybook/sb-addons that contains the manager bundle in some cases might get into the function sanitizeBase as a relative path, example

../../my-module/some-path/foo/bar
and after getting the result from sanitizeBase it would be

--my-module-some-path-foo-bar

The problem with this is that uploading a folder like this to S3 makes it a problem and is not accessible. So this PR basically removes the dashes in case they exist. So in the previous example it would return

my-module-some-path-foo-bar

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@MarioCadenas MarioCadenas requested a review from a team as a code owner June 8, 2023 07:51
@ndelangen ndelangen self-assigned this Jun 8, 2023
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 8, 2023
@ndelangen

Copy link
Copy Markdown
Member

Thank you @MarioCadenas !

@MarioCadenas

Copy link
Copy Markdown
Contributor Author

Thank you @MarioCadenas !

A pleasure! thanks for the fast review! 😄

@ndelangen ndelangen merged commit 7f1ffa7 into storybookjs:next Jun 8, 2023
@MarioCadenas MarioCadenas deleted the fix/build-manager-path-generation branch June 8, 2023 13:13
@JReinhold JReinhold changed the title fix: Build manager adding multiple dashes to relative path Fix: builder-manager adding multiple dashes to relative path Jun 9, 2023
@JReinhold JReinhold changed the title Fix: builder-manager adding multiple dashes to relative path Core: Fix builder-manager adding multiple dashes to relative path Jun 9, 2023
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
@github-actions github-actions Bot mentioned this pull request Jun 13, 2023
69 tasks
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2023
…neration

fix: Build manager adding multiple dashes to relative path
(cherry picked from commit 7f1ffa7)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants