Core: Fix builder-manager adding multiple dashes to relative path#22974
Merged
ndelangen merged 3 commits intoJun 8, 2023
Conversation
ndelangen
approved these changes
Jun 8, 2023
Member
|
Thank you @MarioCadenas ! |
Contributor
Author
A pleasure! thanks for the fast review! 😄 |
builder-manager adding multiple dashes to relative path
builder-manager adding multiple dashes to relative pathbuilder-manager adding multiple dashes to relative path
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
Merged
69 tasks
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
When building a standalone storybook, using the function
buildStaticStandaloneand having a manager.ts inside the main configDir of storybook, the folder generated inside the storybook/sb-addons that contains the manager bundle in some cases might get into the functionsanitizeBaseas a relative path, example../../my-module/some-path/foo/barand after getting the result from sanitizeBase it would be
--my-module-some-path-foo-barThe problem with this is that uploading a folder like this to S3 makes it a problem and is not accessible. So this PR basically removes the dashes in case they exist. So in the previous example it would return
my-module-some-path-foo-barHow to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]