Skip to content

UI: Add stricter types to the language property of the SyntaxHighlighter#22790

Merged
ndelangen merged 7 commits into
nextfrom
valentin/stricter-types-for-syntaxhighlighter-language
Nov 29, 2023
Merged

UI: Add stricter types to the language property of the SyntaxHighlighter#22790
ndelangen merged 7 commits into
nextfrom
valentin/stricter-types-for-syntaxhighlighter-language

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented May 25, 2023

Closes N/A

What I did

Add stricter types to the language property of the SyntaxHighlighter

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label May 25, 2023
yannbf
yannbf approved these changes May 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yannbf yannbf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems to be a breaking change, so please test it and see how it would affect existing scenarios

@valentinpalkovic valentinpalkovic force-pushed the valentin/stricter-types-for-syntaxhighlighter-language branch from 28cb78e to 324279b Compare May 25, 2023 12:31
@valentinpalkovic valentinpalkovic force-pushed the valentin/stricter-types-for-syntaxhighlighter-language branch from 1d3e176 to 3bc6572 Compare May 25, 2023 13:04
@valentinpalkovic valentinpalkovic force-pushed the valentin/stricter-types-for-syntaxhighlighter-language branch from a48e06e to f26a28d Compare May 25, 2023 13:37
@ndelangen ndelangen changed the title Add stricter types to the language property of the SyntaxHighlighter UI: Add stricter types to the language property of the SyntaxHighlighter Nov 28, 2023
@ndelangen ndelangen merged commit 428383f into next Nov 29, 2023
@ndelangen ndelangen deleted the valentin/stricter-types-for-syntaxhighlighter-language branch November 29, 2023 00:02
@github-actions github-actions Bot mentioned this pull request Nov 29, 2023
Merged
36 tasks
@github-actions github-actions Bot mentioned this pull request Dec 7, 2023
Closed
44 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 27, 2023 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against b586722

@valentinpalkovic valentinpalkovic removed the maintenance User-facing maintenance tasks label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yannbf yannbf yannbf approved these changes

@ndelangen ndelangen ndelangen approved these changes

@cdedreuille cdedreuille Awaiting requested review from cdedreuille

@JReinhold JReinhold Awaiting requested review from JReinhold

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

Assignees

@yannbf yannbf

Labels

BREAKING CHANGE ci:normal ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentinpalkovic @yannbf @ndelangen