Core: Fix managerHead preset in main.ts#22701
Merged
Merged
Conversation
…it can be overloaded by user in main.ts
shilman
requested changes
May 23, 2023
Member
shilman
left a comment
There was a problem hiding this comment.
I added a "how to test" section to the description if we want to support the 6.5 API. The default implementation should read the value of manager-head.html if it exists and return its contents.
managerHead configuration possibility in main.tsmanagerHead preset in main.ts
Member
Author
That's what it does, of course.. |
Member
|
@ndelangen it just returns the filename. It does not return the contents of the file. Pleas read my "how to test" addition to the PR description |
Member
Author
|
Understood, I'll fix it. |
Member
Author
shilman
approved these changes
May 24, 2023
Closed
shilman
added a commit
that referenced
this pull request
May 24, 2023
Core: Fix `managerHead` preset in `main.ts`
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #22597
What I did
I moved the code to load manager-head.html to a preset value, then get the value needed by the builder-manager via presrt.apply.
This allows the user to set this value via main.ts if they so desire.
I also added this as a valid presetProperty in
StorybookConfiginterface.How to test
In a sandbox: