Vite: Fix missing @storybook/global dependency#22700
Merged
Merged
Conversation
ndelangen
added
bug
patch:yes
yannbf
changed the title
Contributor
|
HI @ndelangen i had an issue with this yesterday, May i review it and merge it if it works fine |
Member
Author
|
Yes, and Yes! @chakAs3 ! ❤️ |
shilman
changed the title
shilman
reviewed
May 23, 2023
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
@ndelangen Fix looks reasonable, but how to test? The sandbox seems to be working fine even without the change.
shilman
approved these changes
May 23, 2023
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
Merging since this looks reasonable, but would be nice to have a test for this in the monorepo somehow
Member
|
I think to test it out, you'd need to start up a sandbox with |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 23, 2023
…al-dep Vite: Fix missing @storybook/global dependency
This was referenced May 23, 2023
Closed
Merged
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22695
What I did
This package is referenced in the code, but there was no dependency in the package.json
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]