Skip to content

fix(cli): make use of -y flag in eslint suggestion#22624

Closed
adam-kov wants to merge 2 commits into
storybookjs:nextfrom
adam-kov:fix/cli-use-yes-option
Closed

fix(cli): make use of -y flag in eslint suggestion#22624
adam-kov wants to merge 2 commits into
storybookjs:nextfrom
adam-kov:fix/cli-use-yes-option

Conversation

@adam-kov
Copy link
Copy Markdown

Closes #22623

What I did

I've changed the CLI to check for the --yes option before asking the user whether they want to install the eslint-plugin-storybook or not.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["bug"]

@JReinhold
Copy link
Copy Markdown
Contributor

Thanks for the contribution!

Is this superceded by #22651 ?

@adam-kov
Copy link
Copy Markdown
Author

Yes, it's the same. I'm gonna close this as that PR is merged already.

@adam-kov adam-kov closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: --yes option isn't used to automatically answer prompts of the CLI

3 participants