Build: Fix sandbox generation scripts#22620
Merged
Merged
Conversation
ndelangen
added
patch:yes
yannbf
requested changes
May 18, 2023
Member
yannbf
left a comment
yannbf
left a comment
There was a problem hiding this comment.
Please do the same for other sandbox scripts that have a similar logic 🙏
yannbf
requested changes
May 18, 2023
| name: 'Vue-CLI (Vue2 JS)', | ||
| script: | ||
| 'npx -p @vue/cli vue create . --default --packageManager=yarn --force --merge --preset="Default (Vue 2)" && echo "module.exports = {}" > webpack.config.js', | ||
| 'npx -p @vue/cli vue create . --default --packageManager=yarn --force --merge --preset="Default (Vue 2)" && cd {{beforeDir}} && echo "module.exports = {}" > webpack.config.js', |
Member
There was a problem hiding this comment.
All these vite commands were not using {{beforeDir}} but rather . so it worked without this change. I think it's better to use {{beforeDir}} so can you change the . to {{beforeDir}} and test it if all works well?
yannbf
approved these changes
May 18, 2023
yannbf
changed the title
5 tasks
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
…tion-script Build: Fix sandbox generation scripts
Merged
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we have the sandbox generation github action failing.