only connect to serverChannel in development mode#22575
Merged
Conversation
ndelangen
added
bug
patch:yes
tmeasday
reviewed
May 17, 2023
Member
tmeasday
left a comment
tmeasday
left a comment
There was a problem hiding this comment.
LGTM. What about the preview side?
Member
Author
|
@tmeasday here's what I could find: These 2 places seem unguarded indeed. |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
…ger-fix only connect to serverChannel in development mode
Merged
shilman
removed
the
patch:done
shilman
added a commit
that referenced
this pull request
May 22, 2023
…nel-manager-fix" This reverts commit 2aef693.
shilman
pushed a commit
that referenced
this pull request
May 23, 2023
…ger-fix only connect to serverChannel in development mode
Merged
shilman
added
the
patch:done
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I made it so the manager frame only attempts to connect to the serverChannel in development-mode.