CLI: Reduce installation noise and improve error handling#22554
Merged
Conversation
a670366 to
5709e45
Compare
shilman
reviewed
May 15, 2023
Member
|
RE: UX can we show a CLI spinner while the installation is occurring now that we're swallowing all the installer output? Also we probably need to handle |
valentinpalkovic
requested changes
May 15, 2023
yannbf
commented
May 15, 2023
yannbf
commented
May 15, 2023
04ac08c to
b201226
Compare
Member
Author
|
TODO: Move And make sure this yields the correct result when users do Ctrl + C in the middle of init, rather than generate an error that is unrelated! |
ndelangen
reviewed
May 19, 2023
ndelangen
approved these changes
May 19, 2023
valentinpalkovic
approved these changes
May 19, 2023
shilman
approved these changes
May 19, 2023
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
…-noise CLI: Reduce installation noise and improve error handling
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22343
What I did
Before, errors thrown by
addDepsfrom our package manager proxies would always look something like this, without proper explanation:In this PR, I do a few things:
orapackage to display spinner in the CLI (now that users don't see progress they might end up quitting the CLI if we don't display a spinner)Before:

After (example for each package manager):

And an example of how the log file looks like:

Spinners in action:

How to test
STORYBOOK_DISABLE_TELEMETRY=true storybook initcommand (using the built binary) in thosewhen testing the
initcommand, you can also pass a package manager via the--package-managerflagChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]