Skip to content

Blocks: Add of prop to Subtitle#22552

Merged
JReinhold merged 18 commits into
storybookjs:nextfrom
joaonunomota:subtitle-of-prop
Apr 22, 2024
Merged

Blocks: Add of prop to Subtitle#22552
JReinhold merged 18 commits into
storybookjs:nextfrom
joaonunomota:subtitle-of-prop

Conversation

@joaonunomota

@joaonunomota joaonunomota commented May 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes part of #22490

What I did

  • Add support for of prop via useOf with "meta" as only valid type
  • Default to extracting content from parameters.docs.subtitle
  • Deprecate extracting content from parameters.componentSubtitle
  • Add stories for several possible applications of Subtitle
  • Update docs and migration files
  • Fix typo in EmptyExample

How to test

  1. Run yarn storybook:blocks
  2. Open Storybook in your browser
  3. Access Subtitle stories

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach mentioned this pull request May 15, 2023
Open
19 tasks
@Sidnioulz Sidnioulz mentioned this pull request Aug 5, 2023
Merged
5 tasks
kylegach
kylegach reviewed Aug 7, 2023
View reviewed changes
Comment thread docs/api/doc-block-subtitle.md Outdated

`Subtitle` is configured with the following props:

### `of`

@kylegach kylegach Aug 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the API reference! ❤️

Could you please keep these props in alphabetical order?

@joaonunomota joaonunomota Aug 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted :)

@joaonunomota joaonunomota requested a review from kylegach August 7, 2023 22:58
@Wilson2k Wilson2k mentioned this pull request Aug 16, 2023
Merged
2 tasks
@joaonunomota joaonunomota changed the title Upgrade Subtitle block to the new v7 blocks API Doc Blocks: Add support for of prop to Subtitle Oct 27, 2023
@joaonunomota

joaonunomota commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

@JReinhold Hi! Is there anything that I can update / fix for a pull request review? It would be nice if this PR and #23728 could go out with #23849.

@JReinhold

JReinhold commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Sorry @joaonunomota I've missed this. I'll review this early next week

@ndelangen ndelangen changed the title Doc Blocks: Add support for of prop to Subtitle Blocks: Add support for of prop to Subtitle Nov 28, 2023
@ndelangen ndelangen added the ci:normal Run our default set of CI jobs (choose this for most PRs). label Nov 28, 2023
@ndelangen

ndelangen commented Nov 29, 2023

Copy link
Copy Markdown
Member

@JReinhold please review?

@nx-cloud

nx-cloud Bot commented Apr 22, 2024 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c204ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

JReinhold
JReinhold approved these changes Apr 22, 2024
View reviewed changes

@JReinhold JReinhold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fantastic work, I'm sorry it took so long for me to properly review it. <3

@JReinhold JReinhold merged commit 2bff7a1 into storybookjs:next Apr 22, 2024
@JReinhold JReinhold mentioned this pull request Apr 22, 2024
Merged
@github-actions github-actions Bot mentioned this pull request May 3, 2024
Merged
44 tasks
@shilman shilman changed the title Blocks: Add support for of prop to Subtitle Blocks: Add of prop to Subtitle May 5, 2024
@shilman shilman mentioned this pull request May 15, 2024
Closed
@JReinhold JReinhold mentioned this pull request May 15, 2024
Merged
8 tasks
@jorge-ji jorge-ji mentioned this pull request May 17, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JReinhold JReinhold JReinhold approved these changes

@cdedreuille cdedreuille Awaiting requested review from cdedreuille

@jonniebigodes jonniebigodes Awaiting requested review from jonniebigodes jonniebigodes is a code owner

@kylegach kylegach Awaiting requested review from kylegach kylegach is a code owner

Assignees

@JReinhold JReinhold

Labels

addon: docs block: other ci:normal Run our default set of CI jobs (choose this for most PRs). feature request

Projects

Core Team Projects
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaonunomota @JReinhold @ndelangen @kylegach