Skip to content

Fix broken link in Storybook and docs#22535

Merged
jonniebigodes merged 6 commits into
storybookjs:nextfrom
joaonunomota:fix-broken-links
May 15, 2023
Merged

Fix broken link in Storybook and docs#22535
jonniebigodes merged 6 commits into
storybookjs:nextfrom
joaonunomota:fix-broken-links

Conversation

@joaonunomota
Copy link
Copy Markdown
Contributor

What I did

I replaced the links to https://storybook.js.org/support with links to https://storybook.js.org/community#support. The current links point to a page that was removed during this pull request storybookjs/frontpage#383, specifically in this commit storybookjs/frontpage@19f09e0.

How to test

Storybook:

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access the about or keyboard shortcut pages
  4. Click on Support link in footer

Docs website:

  1. Go to https://storybook.js.org/docs/angular/get-started/install/ (not framework specific)
  2. Open the troubleshooting pane at the end of the doc
  3. Click on link in "If all else fails, try asking for help"

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@jonniebigodes jonniebigodes added ui documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 12, 2023
@jonniebigodes
Copy link
Copy Markdown
Contributor

@joaonunomota thank you so much for taking the time to put together this pull request and catching this small but rather important typo in Storybook and the documentation. Really appreciate it 🙏 ! Documentation-wise we're all good, one thing though, seems that there's a linting issue and I was wondering if you'd be ok with checking it and following up with us so that we can merge this.

Looking forward to hearing from you. Hope you have a great day.

Stay safe

@joaonunomota
Copy link
Copy Markdown
Contributor Author

@jonniebigodes I think that should make all the checks happy, thank you for the feedback!

Copy link
Copy Markdown
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaonunomota, thanks for addressing the feedback so promptly. Appreciate it 🙏 ! I'm looking at it; it looks good on my end, and the lint check is good. Just waiting on the rest of them to go through, and I'll merge this 🚀

I'd like to follow up with you with one more thing related to this pull request if you're ok. Could you jump into our Discord server and message me (same username)?

Looking forward to hearing from you.

Hope you have a great week.

Stay safe

@joe-vaughan I'll coordinate with you afterward. Sounds good?

@jonniebigodes jonniebigodes merged commit 9655d80 into storybookjs:next May 15, 2023
@joaonunomota joaonunomota deleted the fix-broken-links branch May 15, 2023 15:52
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 16, 2023
shilman pushed a commit that referenced this pull request May 16, 2023
Fix broken link in Storybook and docs
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation patch:done Patch/release PRs already cherry-picked to main/release branch ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants