Sandboxes: Make template names consistent#22466
Merged
Merged
Conversation
yannbf
reviewed
May 9, 2023
| }, | ||
| 'react-webpack/18-ts': { | ||
| name: 'React 18 Webpack5 (TS)', | ||
| name: 'React Webpack (TypeScript)', |
Member
There was a problem hiding this comment.
What do you think is clearer for the general audience?
1:
2:
Contributor
Author
There was a problem hiding this comment.
The first one. If we don't think that's the case, then we should have framework versions on all of the sandboxes. Which would be okay to me, except it wouldn't technically be true, since we're just using @latest, so we'd have to keep the string up-to-date.
Contributor
Author
There was a problem hiding this comment.
The only reason I opted for v3 in Vue, was because I get a sense that the Vue community still hasn't accepted v3 as being the "latest", that v2 and v3 are forks of each other. but I could be wrong.
Member
There was a problem hiding this comment.
Maybe we:
- change JavaScript to JS
- add (latest) for places that do not use v
yannbf
reviewed
May 9, 2023
JReinhold
changed the title
JReinhold
changed the title
yannbf
reviewed
Aug 30, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some of the names of the sandboxes so the naming scheme is more consistent. The names are displayed in the status page.
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]