Skip to content

Adjust child process I/O for compodoc command#22441

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/excessive-compodoc-output
May 11, 2023
Merged

Adjust child process I/O for compodoc command#22441
valentinpalkovic merged 1 commit into
nextfrom
valentin/excessive-compodoc-output

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

Closes #22400

What I did

Refactor package manager's runPackageCommand method to include an optional stdio parameter for better control over child process I/O

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this May 8, 2023
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label May 8, 2023
@valentinpalkovic valentinpalkovic requested a review from yannbf May 8, 2023 08:14
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from 7713e00 to c3aad06 Compare May 8, 2023 09:58
Comment thread code/lib/cli/src/js-package-manager/Yarn1Proxy.ts Outdated
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from c3aad06 to ef3d574 Compare May 11, 2023 07:26
…ional stdio parameter for better control over child process I/O
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from ef3d574 to 99eb500 Compare May 11, 2023 07:51
@valentinpalkovic valentinpalkovic requested a review from yannbf May 11, 2023 07:51
Copy link
Copy Markdown
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you plan on patching this?

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 11, 2023
@valentinpalkovic valentinpalkovic merged commit e1be2e8 into next May 11, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/excessive-compodoc-output branch May 11, 2023 08:54
shilman pushed a commit that referenced this pull request May 22, 2023
…c-output

Adjust child process I/O for compodoc command
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
@shilman shilman mentioned this pull request May 22, 2023
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook fails to build on large Angular projects due to excessive Compodoc output

4 participants