Skip to content

Migrate @storybook/web-components to strict TS#22399

Merged
kasperpeulen merged 4 commits into
storybookjs:nextfrom
efrenaragon96:ts-migrate/sctrict-ts-types
Jun 2, 2023
Merged

Migrate @storybook/web-components to strict TS#22399
kasperpeulen merged 4 commits into
storybookjs:nextfrom
efrenaragon96:ts-migrate/sctrict-ts-types

Conversation

@efrenaragon96

Copy link
Copy Markdown
Contributor

Part of #22176

What I did

Migrate @storybook/web-components to strict TS.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 30, 2023
@kasperpeulen

Copy link
Copy Markdown
Member

@efrenaragon96 Could you resolve the merge conflict?

@efrenaragon96

efrenaragon96 commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

@efrenaragon96 Could you resolve the merge conflict?

Conflict resolved @kasperpeulen, thanks

@kasperpeulen kasperpeulen merged commit 8084da6 into storybookjs:next Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants