CLI: Typescript strict mode#22254
Conversation
|
|
||
| logger.info(`✅ Updating main.js to use vite builder`); | ||
| if (!dryRun) { | ||
| await updateMainConfig({ dryRun, mainConfigPath }, async (main) => { |
There was a problem hiding this comment.
mainConfigPath is declared as optional in RunOptions here
but updateMainConfig expects non-null string. What would be a good fix here?
| } | ||
|
|
||
| if (!eslintFile && !unsupportedExtension) { | ||
| if (!eslintFile || !unsupportedExtension) { |
There was a problem hiding this comment.
I'm pretty sure this is meant to be || here. Let me know if this is a mistake.
| return groups ? [groups[1], groups[2]] : [addon, undefined]; | ||
| if (groups) { | ||
| return [groups[0], groups[2]] as const; | ||
| } | ||
| return [addon, undefined] as const; |
There was a problem hiding this comment.
Probably would have just made more sense to add a tuple return-type to the getVersionSpecifier function definition.
ndelangen
added
maintenance
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @angular-devkit/core@16.2.4, @storybook/client-logger@7.5.3, @storybook/theming@7.5.3 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@SocketSecurity ignore json-parse-even-better-errors@3.0.0 |
ndelangen
requested review from
kasperpeulen,
valentinpalkovic and
yannbf
as code owners
4 participants
Part of #22176
What I did
Fix some typescript errors before enabling strict mode.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]