Skip to content

Build: Migrate @storybook/addon-backgrounds to strict-ts#22178

Merged
ndelangen merged 5 commits into
nextfrom
kasper/strict-ts-backgrounds
Sep 19, 2023
Merged

Build: Migrate @storybook/addon-backgrounds to strict-ts#22178
ndelangen merged 5 commits into
nextfrom
kasper/strict-ts-backgrounds

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Apr 20, 2023

Issuse #22176

What I did

Migrate @storybook/addon-backgrounds to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen requested a review from yannbf April 20, 2023 10:01
@kasperpeulen kasperpeulen self-assigned this Apr 20, 2023
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Apr 20, 2023
@kasperpeulen kasperpeulen force-pushed the kasper/strict-ts-backgrounds branch from 66b03b1 to d4504f1 Compare April 20, 2023 10:07
@kasperpeulen kasperpeulen mentioned this pull request Apr 20, 2023
Closed
Base automatically changed from kasper/strict-ts to next April 25, 2023 07:45
@kasperpeulen kasperpeulen removed their assignment May 1, 2023
@JReinhold JReinhold self-assigned this May 1, 2023
@JReinhold JReinhold self-requested a review May 1, 2023 14:18
@kasperpeulen
Copy link
Copy Markdown
Member Author

kasperpeulen commented May 7, 2023

@yannbf @JReinhold I'm going on holiday Tuesday and could use a hand. Would one of you be able to review this before I leave? I'd really appreciate it, thanks!

@yannbf yannbf requested a review from ndelangen as a code owner September 19, 2023 10:09
@yannbf yannbf added ci:normal maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Sep 19, 2023
@ndelangen ndelangen self-assigned this Sep 19, 2023
@ndelangen ndelangen merged commit aae03b0 into next Sep 19, 2023
@ndelangen ndelangen deleted the kasper/strict-ts-backgrounds branch September 19, 2023 11:14
@github-actions github-actions Bot mentioned this pull request Sep 19, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees

@ndelangen ndelangen

@JReinhold JReinhold

Labels

ci:normal maintenance User-facing maintenance tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasperpeulen @ndelangen @yannbf @JReinhold