Telemetry: Add CLI version to context#21999
Merged
Merged
Conversation
tmeasday
approved these changes
Apr 8, 2023
Member
tmeasday
left a comment
tmeasday
left a comment
There was a problem hiding this comment.
Generally lgtm. Should we test for some value in the telemetry e2e tests?
shilman
added
the
patch:yes
Member
Author
|
@tmeasday tests FTW!! caught a bug in angular, which bypasess the CLI. this is a little messier than it started out as. please re-review and lmk if you have a better idea about how to structure it. |
tmeasday
approved these changes
Apr 10, 2023
Member
tmeasday
left a comment
tmeasday
left a comment
There was a problem hiding this comment.
LGTM. Maybe would be good to refactor this angular stuff to avoid the duplication though.
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 11, 2023
Telemetry: Add CLI version to context
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
We don't enrich boot events with metadata so that it doesn't affect perf, but we can include the CLI version without additional overhead, and it is useful for understanding whether we've fixed bugs across versions.
How to test
In a sandbox: