Skip to content

Bug: Fix incorrect type-file for addon-actions#21922

Merged
ndelangen merged 1 commit into
nextfrom
norbert/fix-21887
Apr 5, 2023
Merged

Bug: Fix incorrect type-file for addon-actions#21922
ndelangen merged 1 commit into
nextfrom
norbert/fix-21887

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Apr 4, 2023

Closes #21887

What I did

Fixes a small issue where types for decorators file from addon-actions was pointing to the wrong .d.ts file in package.json

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this Apr 4, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: actions typescript labels Apr 4, 2023
@ndelangen ndelangen requested a review from kasperpeulen April 4, 2023 16:39
@ndelangen
Copy link
Copy Markdown
Member Author

@jattasNI I think this fixes your issue

@ndelangen ndelangen changed the title fix https://github.com/storybookjs/storybook/issues/21887 Bug: Fix incorrect type-file for addon-actions Apr 4, 2023
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 5, 2023
@ndelangen ndelangen merged commit 57c0d4c into next Apr 5, 2023
@ndelangen ndelangen deleted the norbert/fix-21887 branch April 5, 2023 11:58
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
Bug: Fix incorrect type-file for addon-actions
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: actions maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 7.0.0 - Module '"@storybook/addon-actions/decorator"' has no exported member 'withActions'

3 participants