Skip to content

Don't use prerelease commands in Migration Guide#21918

Merged
jonniebigodes merged 3 commits into
mainfrom
update-migration-guide-for-main
Apr 4, 2023
Merged

Don't use prerelease commands in Migration Guide#21918
jonniebigodes merged 3 commits into
mainfrom
update-migration-guide-for-main

Conversation

@kylegach
Copy link
Copy Markdown
Contributor

@kylegach kylegach commented Apr 4, 2023

What I did

See title

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach self-assigned this Apr 4, 2023
@kylegach
Copy link
Copy Markdown
Contributor Author

kylegach commented Apr 4, 2023

The pretty-docs failure is incorrect. Running that command locally adds a ; after the snippet code block, which is invalid.

Copy link
Copy Markdown
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kylegach , I'm going to go ahead and merge it.

@jonniebigodes jonniebigodes merged commit 35b13ec into main Apr 4, 2023
@jonniebigodes jonniebigodes deleted the update-migration-guide-for-main branch April 4, 2023 16:58
@kylegach kylegach mentioned this pull request Apr 4, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants