Skip to content

update deprecated pnpx references#21839

Merged
ndelangen merged 7 commits into
storybookjs:nextfrom
autoboxer:next
Apr 6, 2023
Merged

update deprecated pnpx references#21839
ndelangen merged 7 commits into
storybookjs:nextfrom
autoboxer:next

Conversation

@autoboxer
Copy link
Copy Markdown
Contributor

@autoboxer autoboxer commented Mar 30, 2023

pnpx has been deprecated in favor of pnpm dlx.

What I did

  1. Updated the deprecated pnpx command in the MIGRATION.md file to pnpm dlx.
  2. Updated snippets containing the deprecated pnpx command to pnpm dlx.
  3. Updated the array of script prefixes in sb-scripts.ts > getStorybookScripts() to include pnpm dlx.

References

the merged pull request in pnpm outlining the deprecation

`pnpx` is deprecated as of pnpm 7, `pnpm dlx` should be used instead.
`pnpx` is deprecated as of pnpm 7, `pnpm dlx` should be used instead.

This will ensure Storybook scripts prefixed with `pnpm dlx` will also be found in calls to `getStorybookScripts()`.
`pnpx` is deprecated as of pnpm 7, `pnpm dlx` should be used instead.
@yannbf
Copy link
Copy Markdown
Member

yannbf commented Apr 3, 2023

Hey @autoboxer thanks a lot for your contribution! ❤️

@IanVS IanVS added the pnpm label Apr 3, 2023
@jonniebigodes
Copy link
Copy Markdown
Contributor

@autoboxer, thanks for taking the time and helping us out by catching this small but rather important issue. We appreciate it 🙏 ! On the documentation front, all is good on my end. @ndelangen already approved it as well. So it's just a matter of waiting on the checklist to clear and this should be good to go.

@autoboxer autoboxer mentioned this pull request Apr 5, 2023
@autoboxer
Copy link
Copy Markdown
Contributor Author

Happy to help @yannbf and @jonniebigodes 🙂

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 6, 2023
@ndelangen ndelangen merged commit e3bc173 into storybookjs:next Apr 6, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
update deprecated pnpx references
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation patch:done Patch/release PRs already cherry-picked to main/release branch pnpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants