Docs: Raw support for mjs, jsx, and tsx files#21671
Merged
Merged
Conversation
Contributor
Author
|
I hope it's okay, I'm marking this as ready for review despite a lack of test automation because I'm not sure how to get started testing this feature automatically, as is it can't even be tested manually without making manual modifications to the testing scaffolds. After taking a glance if you could point me in a good direction I'll continue on those parts of the PR. |
Member
|
Hey @42shadow42 thank you so much for your contribution! Let's involve @ndelangen to help you get started with testing, and @jonniebigodes to chime in regarding possible documentation changes. thanks! |
yannbf
reviewed
Mar 20, 2023
Member
|
Hey @ndelangen do you think this is good to (rebase then) merge? |
mjs, jsx, and tsx files
ndelangen
approved these changes
Nov 28, 2023
…book into pr/42shadow42/21671 # Conflicts: # code/addons/docs/template/stories/stories-mdx/RawSource.jsx # code/addons/docs/template/stories/stories-mdx/raw-source.non-stories.js
36 tasks
5 tasks
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Enabled support for loading truly raw mjs,jsx, and tsx files by disabling the babel-loader when the raw query is set.
How to test
yarn task --task sandbox --template react-webpack/18-tsInstead of:
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]