CLI: Point the update-notice to the changelog in the suggested version#19911
Merged
Conversation
Member
|
@kylegach could you check if this is implemented correctly? will this work? is this a good idea? |
kylegach
reviewed
Apr 19, 2023
kylegach
requested changes
Apr 19, 2023
Contributor
kylegach
left a comment
kylegach
left a comment
There was a problem hiding this comment.
So sorry for letting this sit so long! 🤦♂️
Thanks for catching this detail! The change is great conceptually, but needs an update in how it's executed, which I explained in my other comment.
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Member
|
@kylegach could to give this a review, and merge this PR of all is 👍 ? |
ndelangen
requested review from
JReinhold,
ndelangen,
shilman and
tmeasday
as code owners
kylegach
approved these changes
Nov 28, 2023
Contributor
kylegach
left a comment
kylegach
left a comment
There was a problem hiding this comment.
Thanks for this thoughtful fix, Carlos!
ndelangen
changed the title
ndelangen
changed the title
36 tasks
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The upgrade notice when starting Storybook always points to the CHANGELOG in the
nextbranch. However, if e.g. you're in the 6.x releases, thenextbranch doesn't actually have the changelog for the next 6.x release. An easy way to fix this is to always point to the CHANGELOG residing in the tag corresponding to the suggested version.What I did
Changed
nextas a ref in the changelog URL to the ref of the suggested versionHow to test
If your answer is yes to any of these, please make sure to include it in your PR.