Skip to content

React: Expose ReactFramework type#19704

Merged
kasperpeulen merged 1 commit into
nextfrom
export-react-framework
Nov 2, 2022
Merged

React: Expose ReactFramework type#19704
kasperpeulen merged 1 commit into
nextfrom
export-react-framework

Conversation

@IanVS

@IanVS IanVS commented Nov 1, 2022

Copy link
Copy Markdown
Member

Issue: N/A

What I did

Re-exported the type ReactFramework from @storybook/react, to support uses like @storybook/testing-react in storybookjs/testing-react#120. I think it wasn't intentionally made private.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS requested a review from kasperpeulen November 1, 2022 20:12
@IanVS IanVS changed the title Expose ReactFramework type React: Expose ReactFramework type Nov 1, 2022
@kasperpeulen kasperpeulen merged commit 426c6c0 into next Nov 2, 2022
@kasperpeulen kasperpeulen deleted the export-react-framework branch November 2, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants