Skip to content

Vue: Add babel loader 9.0.0 to vue-webpack5 peer dependencies#19697

Merged
shilman merged 1 commit into
storybookjs:nextfrom
SebastianKapunkt:vue-webpack-5-babel
Nov 2, 2022
Merged

Vue: Add babel loader 9.0.0 to vue-webpack5 peer dependencies#19697
shilman merged 1 commit into
storybookjs:nextfrom
SebastianKapunkt:vue-webpack-5-babel

Conversation

@SebastianKapunkt
Copy link
Copy Markdown
Contributor

@SebastianKapunkt SebastianKapunkt commented Nov 1, 2022

Issue: In our project, we would like to update babel loader to 9.0.0 and above. Currently, the vue-webpack-5 package from storybook is blocking this update.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @storybook/vue@6.5.13
npm ERR! Found: babel-loader@9.0.0
npm ERR! node_modules/babel-loader
npm ERR!   dev babel-loader@"^9.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer babel-loader@"^7.0.0 || ^8.0.0" from @storybook/vue@6.5.13
npm ERR! node_modules/@storybook/vue
npm ERR!   dev @storybook/vue@"^6.5.13" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: babel-loader@8.2.5
npm ERR! node_modules/babel-loader
npm ERR!   peer babel-loader@"^7.0.0 || ^8.0.0" from @storybook/vue@6.5.13
npm ERR!   node_modules/@storybook/vue
npm ERR!     dev @storybook/vue@"^6.5.13" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-10-31T12_25_40_569Z-debug-0.log

Are there any concerns or other processes to get this live? I'm happy to contribute :)

https://github.com/babel/babel-loader/releases/tag/v9.0.0

What I did

Added babel loader 9.0.0 to peer dependencies of the vue-webpack-5 package

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman changed the title vue-webpack-5 Add babel loader 9.0.0 and up to peer dependencies Vue: Add babel loader 9.0.0 to vue-webpack5 peer dependencies Nov 1, 2022
Copy link
Copy Markdown
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @SebastianKapunkt !!!

We'll update the PR soon to get CI running properly

@shilman shilman merged commit aeaced7 into storybookjs:next Nov 2, 2022
@SebastianKapunkt SebastianKapunkt deleted the vue-webpack-5-babel branch November 2, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants