Vue: Add babel loader 9.0.0 to vue-webpack5 peer dependencies#19697
Merged
Conversation
6873ab6 to
04a16c3
Compare
shilman
approved these changes
Nov 1, 2022
Member
shilman
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @SebastianKapunkt !!!
We'll update the PR soon to get CI running properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: In our project, we would like to update babel loader to 9.0.0 and above. Currently, the vue-webpack-5 package from storybook is blocking this update.
Are there any concerns or other processes to get this live? I'm happy to contribute :)
https://github.com/babel/babel-loader/releases/tag/v9.0.0
What I did
Added babel loader 9.0.0 to peer dependencies of the vue-webpack-5 package
How to test
If your answer is yes to any of these, please make sure to include it in your PR.