Skip to content

future tag to next#19673

Merged
shilman merged 1 commit into
storybookjs:nextfrom
konsalex:patch-1
Nov 1, 2022
Merged

future tag to next#19673
shilman merged 1 commit into
storybookjs:nextfrom
konsalex:patch-1

Conversation

@konsalex
Copy link
Copy Markdown
Contributor

Issue:

What I did

The next tag is currently used for the latest alpha as pointed by @IanVS , and changed it in the migration document

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

The `next` tag is currently used for the latest `alpha` as pointed by @IanVS
@IanVS
Copy link
Copy Markdown
Member

IanVS commented Oct 28, 2022

@shilman it looks like next might be broken? I'm seeing this error on this PR, but there's no way this change would cause it:

The lockfile would have been modified by this install, which is explicitly forbidden.

@shilman
Copy link
Copy Markdown
Member

shilman commented Oct 28, 2022

@IanVS I think it was a race condition. i was publishing a new version of SB and it was in an inconsistent state for a few minutes when @konsalex opened the PR. if you update from next again i think it will pass

Copy link
Copy Markdown
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @konsalex! Can't update your branch so I'll merge this in spite of CI

@shilman shilman merged commit 66346bb into storybookjs:next Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants