Cleanup: Un-ignore some files from eslint#19670
Merged
Merged
Conversation
IanVS
added
the
cleanup
IanVS
commented
Oct 28, 2022
| // Do not import @storybook/source-loader/extract-source directly. | ||
| // Import @storybook/source-loader instead. | ||
| export * from './dist/types/extract-source.d'; No newline at end of file | ||
| export * from './dist/index'; |
Member
Author
There was a problem hiding this comment.
This likely broke in the move to use tsup to bundle source-loader. It's deprecated though, so not a big deal I think.
Member
There was a problem hiding this comment.
Why index, instead of extract-source.d?
Member
Author
There was a problem hiding this comment.
There is no more extract-source.d, after the change to use ts-up.
| export * from './dist/types/react'; | ||
| export { default } from './dist/types/react'; | ||
| export * from './dist/react'; | ||
| export { default } from './dist/react'; |
Member
Author
There was a problem hiding this comment.
I think this changed in the move to tsup
Member
|
LGTM! |
kasperpeulen
approved these changes
Nov 1, 2022
| // Do not import @storybook/source-loader/extract-source directly. | ||
| // Import @storybook/source-loader instead. | ||
| export * from './dist/types/extract-source.d'; No newline at end of file | ||
| export * from './dist/index'; |
Member
There was a problem hiding this comment.
Why index, instead of extract-source.d?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
As I was poking around I found a few files being ignored from eslint that don't need to be. Un-ignoring them turned up a few small bugs as well.
What I did
Removed
.d.tsandlib/cli/testfiles from being ignored by ESLint, and fixed the linting errors that were exposed.How to test
CI