Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18019
What I did
Running
yarn storybook
with Node 18 fails with the following issue:There was an undocumented change to the "family" attribute in os.networkInterfaces() in Node 18 which made
family
become a number rather than string, as it was before. Therefore that breaks Storybook.This PR bumps
ip
to 2.0.0. Honestly it doesn't seem like 2.0.0 has breaking changes. The real change was this which is backwards compatible.How to test
To test this out I did:
1 - Access a Storybook project e.g. MealDrop
2 - Set node to 18
3 - Run yarn storybook -> See failure
4 - Add resolutions to package.json
5 - Run yarn then yarn storybook -> See success
Would be nice to do more testing, though I'd require assistance (maybe releasing a canary?)
If your answer is yes to any of these, please make sure to include it in your PR.