UI: Pseudo class potential unsafe warning #17911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b35d409. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
approved these changes
Apr 7, 2022
shilman
changed the title
Andarist
approved these changes
Apr 7, 2022
m7kvqbe1
added a commit
to Royal-Navy/design-system
that referenced
this pull request
May 13, 2022
The Storybook app currently throws some `console.errors`. These are warnings from the Emotion library. storybookjs/storybook#17911 storybookjs/storybook#6998 They have been working to resolve them upstream but don't appear to have caught all of them.
m7kvqbe1
added a commit
to Royal-Navy/design-system
that referenced
this pull request
May 13, 2022
The Storybook app currently throws some `console.errors`. These are warnings from the Emotion library. storybookjs/storybook#17911 storybookjs/storybook#6998 They have been working to resolve them upstream but don't appear to have caught all of them.
m7kvqbe1
added a commit
to Royal-Navy/design-system
that referenced
this pull request
May 16, 2022
The Storybook app currently throws some `console.errors`. These are warnings from the Emotion library. storybookjs/storybook#17911 storybookjs/storybook#6998 They have been working to resolve them upstream but don't appear to have caught all of them. Skipping this test until the underlying upstream issue is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "pseudo class potential unsafe warning" issue mentioned here: #17831 (comment)
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.