Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box: make found options selectable with click #1697

Merged
merged 10 commits into from
Aug 25, 2017

Conversation

Hypnosphi
Copy link
Member

This includes moving back to the original react-fuzzy package

Demo

@codecov
Copy link

codecov bot commented Aug 20, 2017

Codecov Report

Merging #1697 into release/3.3 will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #1697      +/-   ##
===============================================
+ Coverage        21.18%   21.24%   +0.06%     
===============================================
  Files              252      252              
  Lines             5694     5695       +1     
  Branches           695      677      -18     
===============================================
+ Hits              1206     1210       +4     
- Misses            3932     3999      +67     
+ Partials           556      486      -70
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/search_box.js 93.93% <100%> (+9.56%) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d588c1...d8cb4c3. Read the comment docs.

@ndelangen ndelangen changed the base branch from master to release/3.3 August 24, 2017 08:41
<SearchBox onSelectStory={onSelectStory} onClose={onClose} stories={stories} />
);

const modal = wrap.find(FuzzySearch).dive();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, haven't seen this before, TIL

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@ndelangen ndelangen merged commit 40366f5 into release/3.3 Aug 25, 2017
@ndelangen ndelangen deleted the original-react-fuzzy branch August 25, 2017 06:00
@shilman shilman mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants