Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addon-info into addons panel #1501

Closed
wants to merge 44 commits into from
Closed
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
53e10dc
Init Info Panel
usulpro Jul 20, 2017
1920cf4
Add react-komposer to Addon-Info
usulpro Jul 21, 2017
3eabb5d
Add decoratorInfo to Addon-Info
usulpro Jul 21, 2017
b003486
Merge branch 'release/3.3' into addon-info-to-panel
ndelangen Jul 21, 2017
ff4776c
Disable precommit
usulpro Aug 8, 2017
82632db
Merge branch 'master' into addon-info-to-panel
usulpro Aug 8, 2017
1c3d9a2
Restore after merging
usulpro Aug 8, 2017
9137eee
Refactoring addon options
usulpro Aug 8, 2017
5fe8b85
Change styles
usulpro Aug 8, 2017
9b3f2c5
Fix panel behavior
usulpro Aug 9, 2017
e3ff456
Rename options.info (options.text) to summary
usulpro Aug 12, 2017
5d7c2d2
Add JSX example
usulpro Aug 12, 2017
a494903
Addon Info package clean-up
usulpro Aug 12, 2017
a21ee5a
Add support of React Element in a single argument
usulpro Aug 13, 2017
e956ae8
Revert "Disable precommit"
usulpro Aug 8, 2017
fbf0406
Merge branch 'master' into addon-info-to-panel
usulpro Aug 13, 2017
fc6a11e
Update snapshots
usulpro Aug 13, 2017
4384397
Fix marksy config
usulpro Aug 14, 2017
0e77b8a
[WIP] Add storybook
usulpro Aug 14, 2017
eda4bfc
Merge branch 'master' into addon-info-to-panel
usulpro Aug 16, 2017
79719c2
Setup Storybook
usulpro Aug 16, 2017
470797f
Add marksy examples to Storybook
usulpro Aug 19, 2017
8a8460c
Switch to remark markdown compiler
usulpro Aug 20, 2017
01ea321
Temporary remove remark-github
usulpro Aug 20, 2017
63e3026
Setup remark compiler
usulpro Aug 22, 2017
33efb58
Adjust Pre component
usulpro Aug 23, 2017
6404f20
Merge branch 'swith-to-remark' into addon-info-to-panel
usulpro Aug 23, 2017
bd33a63
Merge branch 'master' into addon-info-to-panel
usulpro Aug 23, 2017
68f73c3
WIP
usulpro Aug 23, 2017
e8c6db4
Enable remark-github plugin
usulpro Aug 23, 2017
5407663
Merge branch 'master' into addon-info-to-panel
usulpro Aug 23, 2017
edc04fe
Fix linting
usulpro Aug 23, 2017
378067b
Merge branch 'master' into addon-info-to-panel
Hypnosphi Aug 23, 2017
6e90ede
Fix
usulpro Aug 23, 2017
800d014
Do not do date('Label', new Date()) in cra-kitchen-sink
usulpro Aug 23, 2017
51e67d7
Fix tests
usulpro Aug 23, 2017
a9e4b4b
Remove obsolete comment
usulpro Aug 23, 2017
9f89bc4
Merge branch 'release/3.3' into addon-info-to-panel
usulpro Aug 23, 2017
01c6b2a
Short clean-up
usulpro Aug 24, 2017
49e5414
Remove remark-github again
usulpro Aug 24, 2017
5a47cb5
Merge branch 'release/3.3' into addon-info-to-panel
ndelangen Aug 24, 2017
c8a9d0f
Merge remote-tracking branch 'origin/addon-info-to-panel' into addon-…
usulpro Aug 24, 2017
7a2812a
Revert "Remove remark-github again"
usulpro Aug 24, 2017
079bae9
Get rid of remark plagins
usulpro Aug 24, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions addons/info/.storybook/addons.js
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those disables, they shouldn't be needed and CLI doesn't add them anymore


import '@storybook/addon-info/register';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's concentrate to make cra-kitchen-sink THE place where we all add working examples.

Adding a dev-setup to all packages is just going to get so hard to manage over time.

Do you agree?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see my comment below

import '@storybook/addon-knobs/register';
import '@storybook/addon-actions/register';
import '@storybook/addon-links/register';
import '@storybook/addon-options/register';
33 changes: 21 additions & 12 deletions addons/info/.storybook/config.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
import React from 'react';
import { configure, setAddon, addDecorator } from '@storybook/react';
import InfoAddon from '../src/';
/* eslint-disable import/no-extraneous-dependencies, import/no-unresolved, import/extensions */

addDecorator((story) => (
<div style={{padding: 20}}>
{story()}
</div>
));
import { configure, setAddon } from '@storybook/react';
import { withInfo, setInfoOptions } from '@storybook/addon-info';
import { setOptions } from '@storybook/addon-options';

setAddon(InfoAddon);
setOptions({
downPanelInRight: true,
})

configure(function () {
require('../example/story');
}, module);
setAddon({
summary(info) {
return this.addDecorator(story => {
setInfoOptions(info);
return story();
})
}
});

function loadStories() {
require('../src/components/stories');
}

configure(loadStories, module);
4 changes: 0 additions & 4 deletions addons/info/.storybook/user/modify_webpack_config.js

This file was deleted.

28 changes: 0 additions & 28 deletions addons/info/.storybook/webpack.config.js

This file was deleted.

85 changes: 0 additions & 85 deletions addons/info/CHANGELOG.md

This file was deleted.

Binary file removed addons/info/docs/home-screenshot.png
Binary file not shown.
20 changes: 0 additions & 20 deletions addons/info/example/Button.js

This file was deleted.

192 changes: 0 additions & 192 deletions addons/info/example/story.js

This file was deleted.

Loading