Skip to content

Chore: (Docs): Community frameworks location updated #14849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 1 commit into from
May 8, 2021
Merged

Chore: (Docs): Community frameworks location updated #14849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/get-started/installation-problems/marko.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- You can also setup Storybook manually through the Storybook CLI. Add the `--type marko` flag when you initialize Storybook in your project.
- If there's an installation problem, check the [README for the Marko framework](../../app/marko/README.md).
- If there's an installation problem, check the [README for the Marko framework](https://github.com/storybookjs/marko).
2 changes: 1 addition & 1 deletion docs/get-started/installation-problems/mithril.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- You can also setup Storybook manually through the Storybook CLI. Add the `--type mithril` flag when you initialize Storybook in your project.
- If there's an installation problem, check the [README for the Mithril framework](../../app/mithril/README.md).
- If there's an installation problem, check the [README for the Mithril framework](https://github.com/storybookjs/mithril).
2 changes: 1 addition & 1 deletion docs/get-started/installation-problems/rax.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- You can also setup Storybook manually through the Storybook CLI. Add the `--type rax` flag when you initialize Storybook in your project.
- If there's an installation problem, check the [README for the Rax framework](../../app/rax/README.md).
- If there's an installation problem, check the [README for the Rax framework](https://github.com/storybookjs/rax).
2 changes: 1 addition & 1 deletion docs/get-started/installation-problems/riot.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- You can also setup Storybook manually through the Storybook CLI. Add the `--type riot` flag when you initialize Storybook in your project.
- If there's an installation problem, check the [README for the Riot framework](../../app/riot/README.md).
- If there's an installation problem, check the [README for the Riot framework](https://github.com/storybookjs/riot/).
8 changes: 5 additions & 3 deletions docs/snippets/common/storybook-babel-configuration-example.ts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
```ts
// mithril/src/server/framework-preset-mithril.ts
// app/mithril/src/server/framework-preset-mithril.ts

import { TransformOptions } from '@babel/core';

export function babelDefault(config: TransformOptions) {
return {
...config,
plugins: [
...config.plugins,
require.resolve('@babel/plugin-transform-react-jsx')
...config.plugins,
[require.resolve('@babel/plugin-transform-react-jsx'), {}, 'preset'],

@shilman shilman May 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related?

@jonniebigodes jonniebigodes May 7, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking the changes in the repo for mithril and that caught my eye. Compared it with what's currently documented and updated it accordingly so that we're on the safe side. I can always revert it back

],
};
}
Expand Down