Skip to content

add typo fix for running snapshot tests - #14784

Merged
shilman merged 1 commit into
storybookjs:nextfrom
gregogun:patch-1
May 3, 2021
Merged

shilman merged 1 commit into
storybookjs:nextfrom
gregogun:patch-1

Conversation

@gregogun

@gregogun gregogun commented May 2, 2021

Copy link
Copy Markdown
Contributor

What I did

  • When trying to run tests with npx test storybook.test.js nothing seemed to happen for me.
  • Tried npm instead of npx and the tests ran so I guessed it may have been a typo!

- When trying to run tests with 'npx test storybook.test.js' nothing seemed to happen for me. 
- Tried 'npm test storybook.test.js' and the tests ran so I guessed it may have been a typo!
@gregogun
gregogun requested review from ndelangen and shilman as code owners May 2, 2021 16:32
@nx-cloud

nx-cloud Bot commented May 2, 2021 •

Copy link
Copy Markdown

Nx Cloud Report

CI ran the following commands for commit 1ef1233. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added addon: docs patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 3, 2021
@shilman
shilman merged commit d2f2561 into storybookjs:next May 3, 2021
@shilman shilman added documentation patch:done Patch/release PRs already cherry-picked to main/release branch and removed addon: docs labels May 3, 2021
shilman added a commit that referenced this pull request May 8, 2021
add typo fix for running snapshot tests
@yannbf yannbf removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants